tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack #148057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
Enselic
force-pushed
the
hwasan-fix-v2
branch
from
2acc4eb to
150b1dc
Compare
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Oct 24, 2025
tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Enselic
force-pushed
the
hwasan-fix-v2
branch
from
150b1dc to
6f5b3e0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rust-bors bot
added a commit
that referenced
this pull request
Oct 24, 2025
tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Enselic
force-pushed
the
hwasan-fix-v2
branch
from
6f5b3e0 to
1c8c95a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Oct 24, 2025
tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack try-job: aarch64-gnu
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
To avoid linker errors like
relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against `.data.rel.ro..L.hwasan'
we need to have `-C target-feature=+tagged-globals`, which is documented here:
https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html#hwaddresssanitizer
Enselic
force-pushed
the
hwasan-fix-v2
branch
from
1c8c95a to
38a1790
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Oct 24, 2025
tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack try-job: aarch64-gnu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid linker errors like
we need to have
-C target-feature=+tagged-globals, which is documented here. I learned that here.Closes #83989
try-job: aarch64-gnu